Report mean,min,max ConsumeWorkerMetrics::timing_metrics #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolana
force-pushed
the
report_load_execute
branch
2 times, most recently
from
e4781aa to
7db5fe3
Compare
ksolana
force-pushed
the
report_load_execute
branch
from
7db5fe3 to
d19f6be
Compare
apfitzge
reviewed
Oct 28, 2024
| freeze_lock_us: AtomicU64, | ||
| record_us: AtomicU64, | ||
| commit_us: AtomicU64, | ||
| find_and_send_votes_us: AtomicU64, | ||
| wait_for_bank_success_us: AtomicU64, | ||
| wait_for_bank_failure_us: AtomicU64, | ||
| count: AtomicU64, |
There was a problem hiding this comment.
we can just report this instead of mean - can derive the mean of any of the metrics that way instead of a separate point for each.
There was a problem hiding this comment.
yeah i was also thinking that way. glad that you have the same point of view.
apfitzge
reviewed
Oct 28, 2024
| ), | ||
| ( | ||
| "load_execute_us_mean", | ||
| self.load_execute_us.swap(0, Ordering::Relaxed)/self.count.swap(0, Ordering::Relaxed), |
There was a problem hiding this comment.
You need to test the metrics you're adding. This will never be anything be 0 because we have already swapped self.load_execute_us to 0 above
ksolana
force-pushed
the
report_load_execute
branch
from
7240bb3 to
b4fa34a
Compare
|
Updated the commit message with output from the validator log. |
apfitzge
reviewed
Oct 31, 2024
apfitzge
previously approved these changes
Nov 1, 2024
ksolana
force-pushed
the
report_load_execute
branch
from
0d0e933 to
4e76a80
Compare
ksolana
force-pushed
the
report_load_execute
branch
from
4e76a80 to
faa9330
Compare
apfitzge
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Only total time is reported for load_execute
Summary of Changes
Report mean, min, max metrics.
Testing:
$ solana airdrop -u http://127.0.0.1:8899 10 An8CLJA36yAivbBCo3dneq9rQz4h5MqM2exXEre4yheu
Fixes #467