Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bump rust to 1.82.0 (#3308)" #3320

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Oct 25, 2024

Problem

I'm experiencing SIGILL crashes due to invalid opcodes. Maybe it's related to the recent rust 1.82.0 upgrade? Getting a revert PR going so it'll be ready as needed.

I started up two nodes with master, just after the upgrade of rust to 1.82.0 (f8b33755f6b08d03f020bbeae4fd9724f2a407d3). Both nodes crashed. Upon investigating the syslog, both had:

Oct 25 20:20:00 localhost kernel: [6027386.359788] traps: solRspndrGossip[2670083] trap invalid opcode ip:5560731be7d7 sp:7ec4429bd840 error:0 in agave-validator[55607252e000+246e000]
Oct 25 20:20:24 localhost systemd[1]: sol.service: Main process exited, code=killed, status=4/ILL

I built the binaries locally on each machine. I retried on one of the machines three times, and got the same crash each time. I then kept the same commit checked out and built with rust 1.81.0 and there were no more crashes.

Summary of Changes

This reverts commit ed5e30d.

@brooksprumo brooksprumo marked this pull request as ready for review October 25, 2024 23:32
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this to restore stability to master.

I also think we should cut v2.1 with rust 1.81. As Brooks called out, there is seemingly some change of behavior between rust versions that we need to address before bumping back to rust 1.82 anywhere

@brooksprumo
Copy link
Author

Merging. Once the UB fix lands, we can re-upgrade rust to 1.82.0. This unblocks everyone running validators on master.

@brooksprumo brooksprumo merged commit 047dfc0 into anza-xyz:master Oct 28, 2024
19 checks passed
@brooksprumo brooksprumo deleted the revert/3308 branch October 28, 2024 18:12
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants