Runtime: Core BPF Migration: Struct for loading and checking builtin program accounts #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
changed the title
buffalojoec
force-pushed
the
core-bpf-builtins
branch
2 times, most recently
from
668750b to
2af637f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
========================================
Coverage 81.8% 81.8%
========================================
Files 838 840 +2
Lines 227363 227487 +124
========================================
+ Hits 186187 186289 +102
- Misses 41176 41198 +22 |
buffalojoec
force-pushed
the
core-bpf-builtins
branch
from
2af637f to
eb52c6c
Compare
|
Note this can go in separate from #318. |
buffalojoec
force-pushed
the
core-bpf-builtins
branch
from
a8a459e to
52972c7
Compare
This was referenced Mar 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is chunk 3/7 of the broken-up PR #79.
Problem
When the runtime desires to migrate a builtin program to Core BPF, there exists
no reliable method for loading a builtin's program account and performing
various checks to ensure the program account is configured as expected.
Being able to run these checks before fetching the builtin's program account
is extremely important for ensuring a smooth migration to Core BPF.
Summary of Changes
Within the
builtinssubmodule, add a module specifically forcore_bpf_migration,and inside of it create a new structure for loading a builtin's program account and
running checks, based on the type of builtin.