Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates test_bank_hash_internal_state() for accounts lt hash #3269

Merged

Conversation

brooksprumo
Copy link

Problem

When adding feature gate logic for accounts lt hash and mixing it into the bank hash, the test_bank_hash_internal_state test failed. This is because it wasn't freezing the bank before calling hash_internal_state().

Summary of Changes

Update the test so that it works with the non-featurized accounts lt hash code, so that when we add the featurization code, this test won't need to change (or will have minimal changes).

@brooksprumo brooksprumo self-assigned this Oct 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review October 22, 2024 22:27
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit cfa0935 into anza-xyz:master Oct 23, 2024
40 checks passed
@brooksprumo brooksprumo deleted the lthash/test-hash-internal-state branch October 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants