Invoke ancient slots shrinking only if skipping rewrites is enabled #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
dmakarov
added a commit
that referenced
this pull request
Nov 13, 2024
…bled (backport of #3266) (#3580) Invoke ancient slots shrinking only if skipping rewrites is enabled (#3266) (cherry picked from commit 8ff5dae) Co-authored-by: dmakarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ancient slots shrinking currently should be done only when skipping rewrites is enabled. However, the entry function to ancient slots shrinking is unconditionally invoked in ABS.
Summary of Changes
Add a guarding check that prevents invocation of ancient slots shrinking unless the skip rewrites is enabled from the command line or by the feature gate.
This allows us more flexibility in setting up the parameters of the ancient slots shrinking implementation, in particular the changes of #3205.