Move ideal_storage_size calculation before it is used #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
reviewed
Oct 21, 2024
| ) -> AncientSlotInfos { | ||
| let mut ancient_slot_infos = self.calc_ancient_slot_info(slots, tuning); | ||
| // ideal storage size is total alive bytes of ancient storages |
There was a problem hiding this comment.
Can we add a test for this, i.e. after we call collect_sort_filter_ancinet_slots() make sure that ideal_storage_size is updated?
brooksprumo
reviewed
Oct 22, 2024
|
definitely looks like it is working: it used to write 130GB each time, now it writes 57MB (5.7MB * 10). |
that's good. the constant is for another PR. |
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* Move ideal_storage_size calculation before it is used * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
ideal_storage_sizetuning parameter is incorrectly calculated after it needs to be used.Summary of Changes
Move the update of the
ideal_storage_sizetuning parameter to an earlier point in the control flow before it is used.Adjust tests.