Replaces our GroupBy with rust's ChunkBy #3243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We manually implemented GroupBy because it was experimental and only available in rust-nightly. Rust 1.77.0 stabilized this feature, and it is now available in rust-stable as
ChunkBy
. We can replace our copy with rust std.Summary of Changes
Replace our GroupBy with rust's ChunkBy.