Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to properly configure a
TransactionBatchProcessor
, one must use thenew_unitialized
method to create a new batch processor whose program cache is uninitialized. Subsequently, users must obtain a write lock on the cache and update it with the necessary configs (fork graph, loaders).It would be much easier and cleaner to offer a method on the
TransactionBatchProcessor
that can handle all of this setup in one go.Summary of Changes
Introduce
TransactionBatchProcessor::new
for creating a new, fully initialized batch processor with the provided program-runtime configurations.