SVM: API: rename new to new_uninitialized
#3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
svm-api-new-uninit
branch
from
fbb607e to
bd34c9f
Compare
dmakarov
previously approved these changes
Oct 15, 2024
buffalojoec
force-pushed
the
svm-api-new-uninit
branch
from
bd34c9f to
a27d390
Compare
dmakarov
previously approved these changes
Oct 15, 2024
buffalojoec
force-pushed
the
svm-api-new-uninit
branch
from
a27d390 to
ba807e4
Compare
LucasSte
approved these changes
Oct 15, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In SVM land, the
TransactionBatchProcessormethodnewis designed to, as it says, allow consumers to create a new instance of aTransactionBatchProcessor. However, what's not clear from this method is that fact that the program cache created within this method is completely useless, since it's missing:This method should be renamed to reflect the nature of its behavior, and documented.
Summary of Changes
Rename the method to
new_uninitialized, and add some documentation!