v2.0: token-2022: Use mainnet-beta binary in all tools (backport of #3165) #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
#### Problem The binary of token-2022 bundled in program-test and fetch-spl.sh is very out of date with what's currently running on mainnet. #### Summary of changes Update the shared object and version to fetch. (cherry picked from commit 9695566)
|
As mentioned in the note in the PR description, the backport is to make solana-test-validator and program-test line up with the program deployed to mainnet. |
buffalojoec
approved these changes
Oct 15, 2024
bw-solana
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
LGTM.
My read is this falls into the category of bug fix given how out of date the program is with what's on mainnet, which could lead to devex problems when trying to test with solana-test-validator and program-test. It's also low risk given changes are outside the core validator.
Also agree we don't need to backport to v1.18 given transition to v2.0 is coming soon ™️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The binary of token-2022 bundled in program-test and fetch-spl.sh is very out of date with what's currently running on mainnet.
Summary of changes
Update the shared object and version to fetch.
Note: backporting this change to 2.0 only to reflect the current state of the chain. Technically, this could also be backported to 1.18, but people should start adopting the 2.0 tools / crates soon.
This is an automatic backport of pull request #3165 done by Mergify.