v2.0: ledger-tool: Fix create-snapshot default value for output_directory (backport of #3148) #3153
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…3148) The arguments to specify full and incremental snapshot archives paths used to be a global argument; these were moved to only be instantiated on commands that needed them in #1773. But, when the arguments were moved from app-level to subcommand-level, the code that matches the arguments was not updated to look at subcommand-matches instead of app-matches. (cherry picked from commit 1d9947c)
|
My case for BP'ing this is that:
|
|
did we varify that this doesn't lose visibility of global args? i vaguely remember fighting this at one point |
Sorry, not sure I follow the question. These two args are now intentionally subcommand args (ie |
|
i have seen |
|
Quick context for paper-trail - Trent and I discussed the issues that he had previously seen, and we manually banged around with it. We did not believe there to be any bugs in our code per-se; rather, bugs or abnormalities in our very old version of CLAP |
Problem
The arguments to specify full and incremental snapshot archives paths used to be a global argument; these were moved to only be instantiated on commands that needed them in #1773.
But, when the arguments were moved from app-level to subcommand-level, the code that matches the arguments was not updated to look at subcommand-matches instead of app-matches.
Summary of Changes
Examine the correct matches
Fixes #3117
This is an automatic backport of pull request #3148 done by Mergify.