Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce banking capacity #3114

Merged
merged 1 commit into from
Oct 17, 2024
Merged

reduce banking capacity #3114

merged 1 commit into from
Oct 17, 2024

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Oct 8, 2024

Problem

Summary of Changes

  • Reduce maximum banking stage capacity from 700k to 100k

Fixes #

@apfitzge apfitzge self-assigned this Oct 8, 2024
@apfitzge
Copy link
Author

apfitzge commented Oct 8, 2024

Running this change on a staked mainnet beta node.
Will check back in with results after 1 week.

@apfitzge
Copy link
Author

Ran on a staked (50k) MNB node for the past week. Zero drops due to capacity in the time period.

@apfitzge apfitzge marked this pull request as ready for review October 16, 2024 14:14
bw-solana
bw-solana approved these changes Oct 16, 2024
View reviewed changes
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tao-stones
tao-stones approved these changes Oct 16, 2024
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, also checked the produced block size and packet retry counts, looks stable before/after.

image

@apfitzge apfitzge merged commit aa9d5b4 into anza-xyz:master Oct 17, 2024
38 checks passed
@apfitzge apfitzge deleted the reduce_banking_capacity branch October 17, 2024 15:34
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@apfitzge @ray-kast
reduce banking capacity (anza-xyz#3114)
6bd77a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

@bw-solana bw-solana bw-solana approved these changes

@alessandrod alessandrod Awaiting requested review from alessandrod

Assignees

@apfitzge apfitzge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apfitzge @bw-solana @tao-stones