Bank equality includes accounts lt hash #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
commented
Oct 7, 2024
Comment on lines
+619
to
+620
| && !(self.is_accounts_lt_hash_enabled() && other.is_accounts_lt_hash_enabled() | ||
| && *accounts_lt_hash.lock().unwrap() != *other.accounts_lt_hash.lock().unwrap()) |
There was a problem hiding this comment.
The only time the accounts lt hashes compare false is when
- both banks have the accounts lt hash enabled
- and the values of the accounts lt hashes are different
all other cases return true. (e.g. one or both banks have the accounts lt hash disabled.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Banks can compare equal even if their accounts lt hashes are different.
Summary of Changes
Check accounts lt hash when comparing banks.