remove cu price rounding #3047
Merged
remove cu price rounding #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Overall look reasonable, it is essentially a manual revert of solana-labs#31549.
I closed related feature Issue solana-labs#31453.
| /// to be set by bank.feature_set.is_active(round_compute_unit_price::id()) at the moment | ||
| /// the packet is built. | ||
| /// This field can be removed when the above feature gate is adopted by mainnet-beta. | ||
| const ROUND_COMPUTE_UNIT_PRICE = 0b0010_0000; | ||
| /// For tracking performance | ||
| const PERF_TRACK_PACKET = 0b0100_0000; |
There was a problem hiding this comment.
Might be better to change it to 0010_000, so there would be no "gap"?
There was a problem hiding this comment.
These are serialized in banking_trace data, so I think best to keep the meaning of each flag consistent.
ROUND_COMPUTE_UNIT_PRICE is actually an exception since that was populated only in banking_stage's copy of the Packet.
There was a problem hiding this comment.
Still not great to leave a gap in bit flags. If don't want to introduce a break change in banking_trace at the moment, how about tag 0b0010_0000 as UNUSED?
apfitzge
force-pushed
the
remove_cu_rounding_feature
branch
from
540ddc4 to
f9687a3
Compare
apfitzge
force-pushed
the
remove_cu_rounding_feature
branch
from
f9687a3 to
1378868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PacketinsideBankingStagewhich is bad for us moving to zero-copy approachSummary of Changes
Fixes #