Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - external_internal_function_hash_collision #3000

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Sep 27, 2024

Problem

solana-labs#24261 has been activated on all clusters.

Summary of Changes

Hard-codes the RBPF config to true until further cleanup.

Copy link

mergify bot commented Sep 27, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso marked this pull request as ready for review September 27, 2024 11:58
@Lichtso Lichtso requested a review from pgarg66 September 27, 2024 11:58
@Lichtso Lichtso merged commit a31a55e into anza-xyz:master Sep 27, 2024
40 checks passed
@Lichtso Lichtso deleted the cleanup/error_on_syscall_bpf_function_hash_collisions branch September 27, 2024 17:43
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Cleanup of external_internal_function_hash_collision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants