Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Makes loader-v4 the default #2796

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Aug 30, 2024

Problem

Loader-v4 was originally planned as a PRv2 loader, but will be used as default loader (superseding loader-v3) in PRv1 now.

Summary of Changes

  • Renames and rekeys enable_program_runtime_v2_and_loader_v4 to enable_loader_v4.
  • Disables new deployments on loader-v3 when the feature is enabled.
  • WIP: Adjusts tests.

Copy link

mergify bot commented Aug 30, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the rekey/enable_loader_v4 branch 5 times, most recently from 43b7b38 to 221fd7d Compare September 3, 2024 08:18
@Lichtso Lichtso changed the title Rekey - enable_loader_v4 Refactor - Makes loader-v4 the default Sep 3, 2024
@Lichtso Lichtso force-pushed the rekey/enable_loader_v4 branch 5 times, most recently from a1303e6 to f984bbc Compare September 3, 2024 13:38
@Lichtso Lichtso force-pushed the rekey/enable_loader_v4 branch 2 times, most recently from eec5813 to 1cb4d44 Compare September 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant