SVM: Wire up SVMRentCollector
#2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
svm-rent-collector-wiring-up
branch
from
fe60c60 to
9e34f38
Compare
LucasSte
approved these changes
Aug 29, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* SVM: account loader: wire up `SVMRentCollector` * SVM: transaction account state info: wire up `SVMRentCollector` * Runtime: fee distribution: wire up `SVMRentCollector` * Runtime: bank: wire up `SVMRentCollector` * SVM: drop everything unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that we have a trait for rent management that can be used within SVM, and Bank has its own implementation of
SVMRentCollectoron a wrapper type to inject logging and metrics, we can now wire everything up, so that the SVM API becomes generic over someSVMRentCollectorand Bank can provide its custom implementation.Summary of Changes
One at a time, wire up
SVMRentCollector, often in place of theRentCollectorstruct itself.Then drop everything SVM no longer needs (including
solana-metrics).