Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVM: Examples: Add PayTube Example #2474

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

buffalojoec
Copy link

@buffalojoec buffalojoec commented Aug 7, 2024

Problem

The SVM API is now available for downstream user consumption, but we could
use a few examples for how to use it.

Summary of Changes

Going off of the great work in #2217, this PR adds another example of a state
channel (PayTube) built using the SVM API.

@buffalojoec buffalojoec force-pushed the svm-paytube branch 2 times, most recently from 4a575f9 to 1b59bbb Compare August 7, 2024 16:22
@buffalojoec buffalojoec force-pushed the svm-paytube branch 2 times, most recently from 273c7f5 to 2b7fa04 Compare August 7, 2024 21:14
@buffalojoec buffalojoec changed the title [DRAFT] SVM: Examples: Add PayTube Example Aug 7, 2024
@buffalojoec buffalojoec marked this pull request as ready for review August 7, 2024 21:37
dmakarov
dmakarov previously approved these changes Aug 8, 2024
LucasSte
LucasSte previously approved these changes Aug 8, 2024
Comment on lines +85 to +86
/// I think you know why this is a bad idea...
keys: Vec<Keypair>,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.

svm/examples/paytube/src/processor.rs Outdated Show resolved Hide resolved
@buffalojoec buffalojoec dismissed stale reviews from LucasSte and dmakarov via 3264d9a August 8, 2024 15:34
@buffalojoec buffalojoec merged commit 6051e0b into anza-xyz:master Aug 8, 2024
51 checks passed
@buffalojoec buffalojoec deleted the svm-paytube branch August 8, 2024 22:25
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
* SVM: examples: add paytube example

* fix comment

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants