v2.0: Improves panic message if send() fails in streaming_unpack_snapshot() (backport of #2459) #2464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are reports on Discord12 of people hitting panics while sending on a channel during snapshot unpacking. Here's an example:
The
unwrap
doesn't yield the best panic message...Summary of Changes
Improve the panic message.
This is an automatic backport of pull request #2459 done by Mergify.
Backport Reasoning
I'd like to backport this so we have a better panic message. Maybe this help elucidate why some people have been hitting this panic. Minimally I'd like to have the path information the new message provides.
If we do not backport, we'd have to wait until v2.1 before we could get any additional information.
This backport does not change any behavior, just expands the logging.
Footnotes
https://discord.com/channels/428295358100013066/560174212967432193/1270412894026207305 ↩
https://discord.com/channels/428295358100013066/837340113067049050/1270052679309328408 ↩