Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: Improves panic message if send() fails in streaming_unpack_snapshot() (backport of #2459) #2464

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 6, 2024

Problem

There are reports on Discord12 of people hitting panics while sending on a channel during snapshot unpacking. Here's an example:

thread 'solUnpkSnpsht01' panicked at /var/lib/buildkite-agent/builds/release/anza/agave-secondary/accounts-db/src/hardened_unpack.rs:338:45:
called `Result::unwrap()` on an `Err` value: "SendError(..)"
stack backtrace:

The unwrap doesn't yield the best panic message...

Summary of Changes

Improve the panic message.


This is an automatic backport of pull request #2459 done by Mergify.

Backport Reasoning

I'd like to backport this so we have a better panic message. Maybe this help elucidate why some people have been hitting this panic. Minimally I'd like to have the path information the new message provides.

If we do not backport, we'd have to wait until v2.1 before we could get any additional information.

This backport does not change any behavior, just expands the logging.

Footnotes

  1. https://discord.com/channels/428295358100013066/560174212967432193/1270412894026207305

  2. https://discord.com/channels/428295358100013066/837340113067049050/1270052679309328408

@mergify mergify bot requested a review from a team as a code owner August 6, 2024 18:38
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this one slipped through the cracks. We figured out why were seeing the panics, but doesn't hurt to ship this so LGTM

@brooksprumo brooksprumo merged commit 377d19d into v2.0 Aug 16, 2024
39 checks passed
@brooksprumo brooksprumo deleted the mergify/bp/v2.0/pr-2459 branch August 16, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants