Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: ledger-tool: Set initial last full snapshot slot (backport of #2314) #2342

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 29, 2024

Problem

ledger-tool does not set the initial last full snapshot slot for AccountBackgroundService. This could produce invalid incremental snapshots. Ones that are missing zero lamport accounts. In the full snapshot these accounts would still have non-zero lamports, and thus would be resurrected on startup. This is bad.

Summary of Changes

Set the initial last full snapshot slot.

A useful additional piece of info: #2314 (comment)


This is an automatic backport of pull request #2314 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner July 29, 2024 20:06
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 0df68a9 into v1.18 Jul 31, 2024
35 checks passed
@brooksprumo brooksprumo deleted the mergify/bp/v1.18/pr-2314 branch July 31, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants