extract transaction-error crate #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
transaction-error-crate
branch
4 times, most recently
from
8379e54 to
ec6b7ab
Compare
kevinheavey
force-pushed
the
transaction-error-crate
branch
from
ec6b7ab to
a910bff
Compare
kevinheavey
force-pushed
the
transaction-error-crate
branch
from
ff49bf8 to
d04af81
Compare
kevinheavey
force-pushed
the
transaction-error-crate
branch
from
70b4a8a to
a1bf5cf
Compare
Merged
kevinheavey
force-pushed
the
transaction-error-crate
branch
4 times, most recently
from
6ce6203 to
29c1992
Compare
kevinheavey
force-pushed
the
transaction-error-crate
branch
4 times, most recently
from
772ca69 to
2d80c77
Compare
febo
reviewed
Oct 19, 2024
febo
reviewed
Oct 19, 2024
febo
reviewed
Oct 19, 2024
febo
reviewed
Oct 19, 2024
|
Looks good – @yihau could we please have the crate for this? |
…, and fix its solana-instruction dep features
kevinheavey
force-pushed
the
transaction-error-crate
branch
from
888ea11 to
7645aa8
Compare
febo
approved these changes
Oct 22, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* extract transaction-error crate * update TransactionError usage in sdk * fix frozen-abi support * make serde optional in solana-transaction-error * update lock file * fmt * add #[cfg(not(target_os = "solana"))] where applicable * fmt * put solana-transaction-error behind feature "full" * use workspace lints * update digest * make rustc_version optional * avoid frozen-abi build script * add back workspace lints * remove thiserror * remove unused build deps * use solana-instruction directly * move AddressLoaderError and SanitizeMessageError to transaction-error, and fix its solana-instruction dep features * lint * move TransportError to transaction-error crate * use doc_auto_cfg like in anza-xyz#3121 * missing comma * add deprecations to re-exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::signerandsolana_sdk::transactionwould be great to have outside the SDK. For that to happen,solana_sdk::transaction::errorneeds to move to its own crate, otherwise we get a circular dependency.Summary of Changes