Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update base64 to 0.22 #225

Merged
merged 2 commits into from
Mar 13, 2024
Merged

deps: Update base64 to 0.22 #225

merged 2 commits into from
Mar 13, 2024

Conversation

joncinque
Copy link

@joncinque joncinque commented Mar 13, 2024

Problem

As we discovered in #130 (comment), the newer version of the base64 crate fixes an issue with decoding into a fixed-size array.

Summary of Changes

Bump the version of base64 to 0.22.

I believe this is a breaking change in rpc-client-api, since RpcFilterError uses base64::DecodeError at

Base64DecodeError(#[from] base64::DecodeError),
, but maybe that's ok since we're at 2.0 right now.

Fixes #

Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now we have 4 versions of base64 in the tree 🤕
I'm not objecting. It's just a shame about the dependencies and sub-dependencies holding onto old versions.

@joncinque joncinque merged commit e93854c into anza-xyz:master Mar 13, 2024
46 checks passed
@joncinque joncinque deleted the b64bump branch March 13, 2024 19:39
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
* deps: Update base64 to 0.22

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants