Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conditional borsh usage in compute_budget.rs #2221

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix conditional borsh usage in compute_budget.rs #2221

merged 1 commit into from
Jul 22, 2024

Conversation

kevinheavey
Copy link

Problem

Borsh traits are being derived on ComputeBudgetInstruction without cfg_attr which breaks opting out of borsh in the SDK. This command fails:

agave/sdk$ cargo check --no-default-features -F full

Summary of Changes

Put the borsh derivations behind cfg_attr like in the rest of solana-sdk and solana-program.

@kevinheavey kevinheavey requested a review from joncinque July 22, 2024 19:16
joncinque
joncinque approved these changes Jul 22, 2024
View reviewed changes
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing this!

@joncinque joncinque merged commit 0a0bb75 into anza-xyz:master Jul 22, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @joncinque