Make dcou faster and check lib targets as well #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
force-pushed
the
dcou-partition-wip
branch
from
5c79420
to
e11d963
Compare
Closed
ryoqun
force-pushed
the
dcou-partition-wip
branch
from
e11d963
to
8690066
Compare
ryoqun
changed the title
ryoqun
force-pushed
the
dcou-partition-wip
branch
from
8690066
to
b65abe6
Compare
ryoqun
commented
Aug 8, 2024
Comment on lines
+5
to
+6
| scripts/check-dev-context-only-utils.sh check-all-targets "$@" | ||
| scripts/check-dev-context-only-utils.sh check-bins-and-lib "$@" |
There was a problem hiding this comment.
thanks to the new --partition flag, i've changed to shard both modes check-bins (now called check-bins-and-lib) and check-all-targets more evenly.
yihau
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
libtargets aren't checked for dcou. see Fix false negatives in dcou by using patched cargo #1913 for details of this problem.Summary of Changes
Check
libtargets as well and that makes dcou ci jobs even longer. so, usecargo-hack --partitionto accelerate dcou checks. really thanks @taiki-eBefore:
After:
Fixes #