remove qualifer_attr from svm #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
svm-remove-qualifer-attr
branch
from
22090a2 to
ee6d465
Compare
pgarg66
reviewed
Jun 30, 2024
pgarg66
approved these changes
Jul 1, 2024
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
* remove qualifer_attr and just use #[cfg(feature = "dev-context-only-utils")] * update lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The qualifer_attr usage in solana-svm isn't doing anything - it's applying
pubto something that is alreadypub.I'm guessing it used to do something.As it happens, the code in question only needs to exist when dev-context-only-utils is activeSummary of Changes
Remove itReplace it with a simple#[cfg(feature = "dev-context-only-utils"]