v1.18: Deprecate RpcClient::get_stake_activation (backport of #1895) #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Needs rebase on whatever curve25519-dalek fix lands |
* Deprecate RpcClient::get_stake_activation * Fixup redelegation test (cherry picked from commit 114041c)
CriesofCarrots
force-pushed
the
mergify/bp/v1.18/pr-1895
branch
from
e99bbcb
to
0b8e26f
Compare
t-nelson
approved these changes
Jul 2, 2024
CriesofCarrots
approved these changes
Jul 3, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getStakeActivationRPC endpoint has been deprecated since v1.18, but the client methods have not been. This makes it harder to remove from rpc.rsSummary of Changes
Deprecate RpcClient::get_stake_activation
I'm proposing a v1.18 backport to enable removal in v2.0
This is an automatic backport of pull request #1895 done by Mergify.