Make --wait-for-supermajority require --expected-shred-version

[steviez]

Problem

In cluster restart scenarios, an important step is scanning the Blockstore for blocks (shreds) that occur after the chosen restart slot with an incorrect shred version. Supposing the cluster is chosen to be restarted at slot R, the check ensures that any slots > R are purged from the Blockstore before the node enters the wait-for-supermajority loop. If a node skips this step, the node can encounter problems when that block is created again (post cluster restart)

This check only occurs if --wait-for-supermajority AND --expected-shred-version are set; however, --expected-... is currently optional when using --wait-...

Summary of Changes

Our restart instructions typically mention that one should specify --expected-... as well, but we should just enforce it at the CLI level to prevent mistakes / wasted time debuggging.

Forcing this will also enable us to run this sanity check:

agave/core/src/validator.rs

Lines 730 to 738 in 88f6a7a

	if let Some(expected_shred_version) = config.expected_shred_version {
	if expected_shred_version != node.info.shred_version() {
	return Err(format!(
	"shred version mismatch: expected {} found: {}",
	expected_shred_version,
	node.info.shred_version(),
	));
	}
	}

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (e027a8b) to head (cec2f24).
Report is 18 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master     #192    +/-   ##
========================================
  Coverage    81.8%    81.8%            
========================================
  Files         838      838            
  Lines      226389   226526   +137     
========================================
+ Hits       185342   185518   +176     
+ Misses      41047    41008    -39