Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts-db/report number of duplicated accounts found in shrinking #1884

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

HaoranYi
Copy link

@HaoranYi HaoranYi commented Jun 26, 2024

Problem

We want to know how many duplicated accounts when we shrink.

Summary of Changes

Add a stat to report number of duplicated accounts in shrinking.

Fixes #

@HaoranYi HaoranYi force-pushed the accounts-db/report_num_dups branch 2 times, most recently from f3a33cb to 51c24a1 Compare June 26, 2024 23:18
@HaoranYi HaoranYi force-pushed the accounts-db/report_num_dups branch from 51c24a1 to feda2a8 Compare June 27, 2024 00:07
@HaoranYi HaoranYi changed the title accounts-db/report num dups in shrinking accounts-db/report number of duplicated accounts found in shrinking Jun 27, 2024
Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some nits

accounts-db/src/accounts_db.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db.rs Outdated Show resolved Hide resolved
accounts-db/src/accounts_db.rs Outdated Show resolved Hide resolved
Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@HaoranYi HaoranYi merged commit cd6a15d into anza-xyz:master Jun 27, 2024
40 checks passed
@HaoranYi HaoranYi deleted the accounts-db/report_num_dups branch June 27, 2024 20:40
samkim-crypto pushed a commit to samkim-crypto/agave that referenced this pull request Jul 31, 2024
…nza-xyz#1884)

* report num dups in shrinking

* pr changes

---------

Co-authored-by: HaoranYi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants