spl: Update spl-token to v5 #1836
Conversation
There are issues building new Solana projects because they pull in the newest spl-token and related deps, which means that they can get v2 crates which they weren't aware of. This happens because the latest version of spl-token, v4.0.1, allows v2, but v4.0.0 does not. To make things easier for people, we want to make the v2 compatibility a breaking change on spl-token, so people can consciously opt in to v5 when they want to support both crates, and then yank v4.0.1. To safely yank v4.0.1, we need to make sure it's not used in the monorepo, so update to spl-token v5. Note that this needs to be backported.
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
Ah darn, never mind, we might have to update spl to all v2 only crates and then we can do this properly |
|
Closing this since we'll need to upgrade all the SPL deps to v2 only crates per solana-labs/solana-program-library#6897 (comment) |
Problem
There are issues building new Solana projects because they pull in the newest spl-token and related deps, which means that they can get v2 crates which they weren't aware of, as explained at solana-labs/solana-program-library#6897
This happens because the latest version of spl-token, v4.0.1, allows v2, but v4.0.0 does not.
To make things easier for people, we want to make the v2 compatibility a breaking change on spl-token, meaning people can consciously opt in to v2 support by upgrading to spl-token v5.
Summary of Changes
We need to yank spl-token v4.0.1. To safely yank it, we need to make sure it's not used in the monorepo, so update the monorepo to spl-token v5. Note that this needs to be backported.
Once this is merged and agave 2.0.1 is cut, then we can yank spl-token 4.0.1
Fixes #