patches bug in chained Merkle root update #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
previously approved these changes
Jun 11, 2024
behzadnouri
force-pushed
the
patch-chained-merkle-root
branch
from
b954a46 to
ec37140
Compare
AshwinSekar
approved these changes
Jun 11, 2024
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Option::ok_or_else always maps None to Err which is not what was intended in this code. (cherry picked from commit e804bcc)
mergify bot
added a commit
that referenced
this pull request
Jun 11, 2024
…1692) patches bug in chained Merkle root update (#1689) Option::ok_or_else always maps None to Err which is not what was intended in this code. (cherry picked from commit e804bcc) Co-authored-by: behzad nouri <[email protected]>
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…z#1689) (anza-xyz#1692) patches bug in chained Merkle root update (anza-xyz#1689) Option::ok_or_else always maps None to Err which is not what was intended in this code. (cherry picked from commit e804bcc) Co-authored-by: behzad nouri <[email protected]>
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
Option::ok_or_else always maps None to Err which is not what was intended in this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Option::ok_or_elsealways mapsNonetoErrwhich is not what was intended in this code:https://github.com/anza-xyz/agave/blob/362c60505/turbine/src/broadcast_stage/standard_broadcast_run.rs#L248-L254
Summary of Changes
removed
ok_or_else.