Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove superfluous usage of allow(dead_code) #1669

Merged
merged 1 commit into from
Jun 13, 2024
Merged

remove superfluous usage of allow(dead_code) #1669

merged 1 commit into from
Jun 13, 2024

Conversation

kevinheavey
Copy link

@kevinheavey kevinheavey commented Jun 10, 2024 •
edited
Loading

There are some places where removing #[allow(dead_code)] doesn't break any lint checks

@kevinheavey kevinheavey marked this pull request as ready for review June 10, 2024 16:48
yihau
yihau approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@yihau yihau merged commit 7e06883 into anza-xyz:master Jun 13, 2024
51 checks passed
@kevinheavey kevinheavey deleted the remove-superfluous-allow-dead-code branch June 13, 2024 15:11
samkim-crypto pushed a commit to samkim-crypto/agave that referenced this pull request Jul 31, 2024
@kevinheavey @samkim-crypto
remove superfluous usage of allow(dead_code) (anza-xyz#1669)
217689b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihau yihau yihau approved these changes

Assignees
No one assigned
Labels
need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @yihau