SVM: Group transaction processing environment #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
svm-processing-env
branch
from
a73fb17 to
1d88262
Compare
buffalojoec
force-pushed
the
svm-processing-env
branch
from
1d88262 to
7c42678
Compare
buffalojoec
force-pushed
the
svm-processing-env
branch
from
7c42678 to
becfec3
Compare
|
@buffalojoec could you run a node against MNB with this PR? I don't suspect this change to cause any divergence, but it's modifying some part of the transaction processing. So it'll be great to have some coverage there. |
Yep, no problem. I'll spin up a node right now and let it run overnight. |
|
Node seems to be still running healthy for ~16 hours. ID: I'll continue running another >14 hours to cross the next epoch boundary. |
pgarg66
approved these changes
Jun 13, 2024
|
Node continues to hum along through the epoch boundary! |
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
* SVM: introduce `TransactionProcessingEnvironment` * SVM: fold `blockhash` and `lamports_per_signature` into env * SVM: fold `rent_collector` into env * SVM: fold `feature_set` into env * SVM: fold `epoch_stake` into env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
TransactionBatchProcessorCallbackstrait is required for callers who wishto use the
TransactionBatchProcessor. It provides the batch processor with ameans for loading accounts, as well as retrieving information about the runtime
environment.
The
TransactionBatchProcessoralready requires a handful of runtimeconfigurations in its global config, as well as as inputs to
load_and_execute_sanitized_transactions.It would be easier for downstream users of the transaction batch processor if we
coalesced runtime environment configurations.
Summary of Changes
First introduce the
TransactionProcessingEnvironmentas a required input tothe transaction batch processor.
Then, remove environment-related callbacks from
TransactionBatchProcessorCallbacksin favor of the provided environmentobject.