Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves accounts benches into accounts-db crate #164

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

brooksprumo
Copy link

Problem

There are many benches in the runtime crate that should be in the accounts-db crate.

Summary of Changes

Move them.

(and in the second commit, rename fns from test_ to bench_)

@brooksprumo brooksprumo self-assigned this Mar 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (d88050c) to head (acce264).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage    81.8%    81.9%           
=======================================
  Files         838      838           
  Lines      226564   226564           
=======================================
+ Hits       185522   185591   +69     
+ Misses      41042    40973   -69     

@brooksprumo brooksprumo marked this pull request as ready for review March 10, 2024 13:03
@brooksprumo
Copy link
Author

@HaoranYi We can add a bench for the lattice hash in here too.

Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 0e12172 into anza-xyz:master Mar 11, 2024
35 checks passed
@brooksprumo brooksprumo deleted the move-benches branch March 11, 2024 15:34
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants