Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anza migration] Sets client id to Agave #163

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Mar 9, 2024

Problem

The Agave fork still sets the client ID as "SolanaLabs", even though everything else (crates, binaries, etc) has migrated.

Summary of Changes

Set the client id to Agave.

Copy link

mergify bot commented Mar 9, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Mar 9, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@brooksprumo brooksprumo marked this pull request as ready for review March 9, 2024 15:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (d88050c) to head (fc9d66b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         838      838           
  Lines      226564   226568    +4     
=======================================
+ Hits       185522   185559   +37     
+ Misses      41042    41009   -33     

@yihau
Copy link
Member

yihau commented Mar 10, 2024

thank you 🫶 lgtm but I would like to wait for others' insight!

@brooksprumo
Copy link
Author

@willhickey Is this the right incantation to prevent this commit from getting sync'd back to the Labs's repo?

@willhickey
Copy link

@willhickey Is this the right incantation to prevent this commit from getting sync'd back to the Labs's repo?

Yes. I hadn't settled on a string yet, but [anza migration] is perfect

Copy link

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brooksprumo brooksprumo merged commit 0f1ca20 into anza-xyz:master Mar 12, 2024
37 checks passed
@brooksprumo brooksprumo deleted the agave-version branch March 12, 2024 11:46
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
willhickey pushed a commit that referenced this pull request Mar 14, 2024
)

[anza migration] Sets client id to Agave (#163)

(cherry picked from commit 0f1ca20)

Co-authored-by: Brooks <[email protected]>
brooksprumo added a commit that referenced this pull request Mar 14, 2024
)

[anza migration] Sets client id to Agave (#163)

(cherry picked from commit 0f1ca20)

Co-authored-by: Brooks <[email protected]>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants