SVM: Dissolve RuntimeConfig
#1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
svm-dissolve-runtime-config
branch
from
07a3052 to
2936450
Compare
dmakarov
previously approved these changes
Jun 5, 2024
|
I just have to sort the Frozen ABI stuff on Bank and Compute Budget for this to pass CI. |
buffalojoec
force-pushed
the
svm-dissolve-runtime-config
branch
from
2936450 to
aac9755
Compare
dmakarov
approved these changes
Jun 12, 2024
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
* SVM: add `compute_budget` to processing config * bank: add `compute_budget` field * SVM: add `transaction_account_lock_limit` to processing config * bank: add `transaction_account_lock_limit` field * bank: drop `runtime_config` getter * SVM: require `compute_budget` for `prepare_program_cache_for_upcoming_feature_set` * SVM: drop `runtime_config` from batch processor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The transaction batch processor requires a global configuration for
RuntimeConfig-a small configuration object for transaction processing behavior.
Since the batch processor already uses a
TransactionProcessingConfigfor adjustingruntime behavior, it's redundant to also include some configurations in the batch
processor itself globally.
The
log_messages_byte_limitconfig inRuntimeConfigis also not used, since it'salso provided in
TransactionProcessingConfig.Summary of Changes
First refactor
Bankto storecompute_budgetandtransaction_account_lock_limitoutside of SVM.
Then, add
compute_budgetandtransaction_account_lock_limitto the batchprocessor's
TransactionProcessingConfig.Finally, drop
RuntimeConfigfrom the batch processor's global configurations.