Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-sdk] Remove source, destination, and auditor variable names #1533

Merged
merged 2 commits into from
May 30, 2024

Conversation

samkim-crypto
Copy link

@samkim-crypto samkim-crypto commented May 30, 2024

Problem

As part of #671, we want to make the zk-sdk independent of spl token as much as possible. However, throughout the crate, there are variables that are referred to as the source, destination, or auditor.

Summary of Changes

Rename these variables.

  • For ciphertext-commitment equality proofs, there is only one keypair, ciphertext, commitment, and openings, so I just removed the prefixes.
  • For the other proofs, I thought a bit about alternative ways to rename the variables and just ended up with first, second, and third prefixes for simplicity.

Fixes #

@samkim-crypto samkim-crypto marked this pull request as ready for review May 30, 2024 08:19
@samkim-crypto samkim-crypto requested a review from joncinque May 30, 2024 08:19
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samkim-crypto samkim-crypto merged commit ff7c59e into anza-xyz:master May 30, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants