chore: remove unused clippy attributes, derive_partial_eq_without_eq #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
added
the
automerge
brooksprumo
approved these changes
May 29, 2024
There was a problem hiding this comment.
Seems fine to remove these annotations as https://rust-lang.github.io/rust-clippy/master/#/derive_partial_eq_without_eq is now in the nursery, likely due to many false positive reports1.
Footnotes
|
Would leaving these cause any issues? |
|
@CriesofCarrots sorry for the late response. thank you for pointing this out! I didn't notice these files are autogenerated 😢 keeping them are fine. I just try to clean up our codebase. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
this clippy attribute is no longer needed. remove it!