Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zk-sdk] Add equality, pubkey validity, and percentage-with-cap instruction data #1467

Merged
merged 5 commits into from
May 23, 2024

Conversation

samkim-crypto
Copy link

@samkim-crypto samkim-crypto commented May 23, 2024

Problem

The equality, pubkey validity, and percentage-with-cap proof instruction data have yet to be added to the new elgamal proof program.

Summary of Changes

Added the instructions listed above. I think the commits should be pretty straightforward. The main difference should be updating FeeSigmaProof... to PercentageWithCapProof....

Fixes #

@samkim-crypto samkim-crypto marked this pull request as ready for review May 23, 2024 08:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.05063% with 123 lines in your changes are missing coverage. Please review.

Project coverage is 82.7%. Comparing base (9035690) to head (c641033).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1467    +/-   ##
========================================
  Coverage    82.7%    82.7%            
========================================
  Files         872      876     +4     
  Lines      370523   370997   +474     
========================================
+ Hits       306609   307168   +559     
+ Misses      63914    63829    -85     

@samkim-crypto samkim-crypto requested a review from joncinque May 23, 2024 09:52
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@samkim-crypto samkim-crypto merged commit 9dd01f5 into anza-xyz:master May 23, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants