[zk-sdk] Add error types and zero ciphertext instruction #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 871 872 +1
Lines 370333 370472 +139
=========================================
+ Hits 306536 306614 +78
- Misses 63797 63858 +61 |
joncinque
reviewed
May 22, 2024
zk-sdk/src/elgamal_program/errors.rs
Outdated
Comment on lines
13
to
16
| #[error("not enough funds in account")] | ||
| NotEnoughFunds, | ||
| #[error("transfer fee calculation error")] | ||
| FeeCalculation, |
There was a problem hiding this comment.
Should these errors be changed or removed?
There was a problem hiding this comment.
Oh great point! I removed it. Thanks!
There was a problem hiding this comment.
Ok cool! Can you also get rid of NotEnoughFunds?
There was a problem hiding this comment.
Oh oops, removed. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The proof data and instructions for the new elgamal program in zk-sdk are not added yet.
Summary of Changes
I added the zero-ciphertext instruction to start. Once this PR is merged after some feedback, then I think I can add the rest of the proof data in slightly larger chunk PRs.
ProofGenerationErrorandProofVerificationError. These types remain largely the same as in zk-token-sdk and in particular, wrapsRangeProofErrorandSigmaProofError.zero_balanceinstruction data module from zk-token-sdk verbatim to make the diffs in the next commit easier to view.zero_balanceinstruction data. The changes are essentially updatingZeroBalance...toZeroCiphertext...and re-organizing the imports.VerifyZeroCiphertextinstruction in the elgamal proof program.Fixes #