Removes unnecessary tests in snapshot_packager_service.rs #1371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm working to remove
serde_snapshot::reserialize_bank_with_new_accounts_hash()
, and instead only serialize the bank once.One of the tests in
snapshot_packager_service.rs
is to package up a snapshot. The test callssnapshot_bank_utils::package_and_archive_snapshot()
, which callsreserialize
. An observation is that the test in SPS doesn't actually test any code in SPS; it's all snapshot code being tested. The next observation is that we have many tests that exercisepackage_and_archive_snapshot()
, thus the test in SPS can be safely removed as redundant. This removes a caller ofreserialize_bank_with_new_accounts_hash()
, yay!Summary of Changes
Remove the redundant tests in SPS.