-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVM: Add doc comments, restrict visibility of some xfaces to crate #136
Conversation
0102efb
to
3eae916
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
========================================
Coverage 81.8% 81.8%
========================================
Files 838 838
Lines 226294 226465 +171
========================================
+ Hits 185271 185416 +145
- Misses 41023 41049 +26 |
f15d514
to
2888eee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future, please avoid making so many changes in the same pr. at least the test re-organization, docs comments and other refactoring were all valid, independent PRs
point taken |
Problem
Some functions in SVM crate are visible outside the crate, although they're not part of public API.
Summary of Changes
Restrict visibility of functions not used outside SVM crate to the crate only. Add documentation comments. Rearrange the methods of structs according to visibility moving public methods to the beginning of file.