Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: readonly_write_lock #1336

Merged
merged 3 commits into from
May 16, 2024
Merged

clippy: readonly_write_lock #1336

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
789814d
clippy: readonly_write_lock
yihau May 14, 2024
288a01b
add some comment
yihau May 16, 2024
ed7b420
update comments
yihau May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ledger/src/blockstore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10979,6 +10979,7 @@ pub mod tests {
let slot = shreds[0].slot();
// Grab this lock to block `get_slot_entries` before it fetches completed datasets
// and then mark the slot as dead, but full, by inserting carefully crafted shreds.
#[allow(clippy::readonly_write_lock)]
steviez marked this conversation as resolved.
Show resolved Hide resolved
let _lowest_cleanup_slot =
blockstore.lowest_cleanup_slot.write().unwrap();
blockstore.insert_shreds(shreds, None, false).unwrap();
Expand Down
Loading