Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deactivate hmac feature of libsecp256k1 where not needed #1286

Merged
merged 2 commits into from
May 13, 2024

Conversation

kevinheavey
Copy link

Problem

The workspace Cargo.toml activates the hmac feature of libsecp256k1 which brings in a hmac dependency that is not used outside of solana-sdk.

Summary of Changes

  • Sets default-features to false in the workspace Cargo.toml but explicitly keeps the non-hmac features that were previously being activated as default features.
  • Activates the hmac feature in solana-sdk where it actually is needed

libsecp256k1 0.6.0 default features are here:
https://github.com/paritytech/libsecp256k1/blob/e5095a8930de6f2ae2003c164eba9bfb7ce2f628/Cargo.toml#L34

@mergify mergify bot requested a review from a team May 10, 2024 12:59
@CriesofCarrots CriesofCarrots added the CI Pull Request is ready to enter CI label May 10, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label May 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (e621336) to head (2185e86).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1286     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         899      899             
  Lines      237263   237263             
=========================================
- Hits       194810   194805      -5     
- Misses      42453    42458      +5     

@CriesofCarrots CriesofCarrots merged commit af6930d into anza-xyz:master May 13, 2024
54 checks passed
@kevinheavey kevinheavey deleted the program-remove-hmac-dep branch May 14, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants