Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVM: Move nonce_info from SDK to SVM #1228

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

dmakarov
Copy link

@dmakarov dmakarov commented May 7, 2024

because it's not something we want to be subjected to the backwards compatibility policy.

follow up solana-labs#35138

@dmakarov dmakarov force-pushed the nonce branch 4 times, most recently from 65ede61 to 1539070 Compare May 7, 2024 16:29
because it's not something we want to be subjected to the backwards compatibility policy.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (4ae2ca1) to head (052581d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1228   +/-   ##
=======================================
  Coverage    82.1%    82.1%           
=======================================
  Files         886      886           
  Lines      236439   236484   +45     
=======================================
+ Hits       194252   194292   +40     
- Misses      42187    42192    +5     

@dmakarov dmakarov requested review from jstarry and pgarg66 May 7, 2024 18:41
@dmakarov dmakarov marked this pull request as ready for review May 7, 2024 18:41
Copy link

@pgarg66 pgarg66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @jstarry to take a look at it before merging.

@dmakarov dmakarov merged commit b284eb0 into anza-xyz:master May 8, 2024
48 checks passed
@dmakarov dmakarov deleted the nonce branch May 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants