cli: Use --use-rpc flag correctly during program deployments #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 855 856 +1
Lines 232194 232194
=========================================
- Hits 190222 190215 -7
- Misses 41972 41979 +7 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
cli: Use --use-rpc flag correctly (cherry picked from commit 550f806)
mergify bot
added a commit
that referenced
this pull request
Apr 24, 2024
…backport of #1008) (#1011) cli: Use --use-rpc flag correctly during program deployments (#1008) cli: Use --use-rpc flag correctly (cherry picked from commit 550f806) Co-authored-by: Jon C <[email protected]>
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…backport of anza-xyz#1008) (anza-xyz#1011) cli: Use --use-rpc flag correctly during program deployments (anza-xyz#1008) cli: Use --use-rpc flag correctly (cherry picked from commit 550f806) Co-authored-by: Jon C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noticed in #928 (comment), the logic for
--use-rpcis unfortunately backwards, since it's creating the tpu client ifuse_rpcis true, when we only want to create it when it's false.Summary of Changes
Reverse the logic with a
!Big thanks to @amilkov3 for noticing and reporting this