SVM: move TransactionProcessingCallback into its own module
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
isolate-tx-callback
branch
from
bd4843b to
b74f8b9
Compare
Lichtso
approved these changes
Apr 23, 2024
buffalojoec
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As the SVM continues to grow, we should do our very best to ensure the
entrypoint -
TransactionBatchProcessor::load_and_execute_sanitized_transactions- remainsas simple as possible. It should make use of other adjacent components to
accomplish its goal.
In that spirit, we can modularize the components it needs, starting with the
TransactionProcessingCallback.Summary of Changes
Move
TransactionProcessingCallbackinto its own module within the SVM.