[LLM] Fixed fine-tuning template username setup #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvspraveen
reviewed
Mar 11, 2024
templates/fine-tune-llm/train.py
Outdated
| @@ -33,7 +33,7 @@ def generate_model_tag(model_id: str) -> str: | |||
| """ | |||
| username = os.environ.get("ANYSCALE_USERNAME") | |||
| if username: | |||
| username = username[:5] | |||
| username = username.strip().replace(" ", "_")[:5] | |||
There was a problem hiding this comment.
nit: this may add _ to the end sometimes
>>> username = "Kyle abcde"
>>> username = username.strip().replace(" ", "_")[:5]
>>> username
'Kyle_'
You can avoid that by following
username[:5].strip().replace(" ", "_")
But with my suggestion you could end up with username less than 5 characters sometimes
There was a problem hiding this comment.
Is it OK to have username less than 5?
I actually submitted a PR #126 to append username to be 5
There was a problem hiding this comment.
Updated logic so we never have _ in case there are issues with it and always padded it to be length 5.
I think it's okay to have username less than 5 but just in case it's length 0 for some reason, I always added padding
gvspraveen
approved these changes
Mar 11, 2024
anmscale
pushed a commit
that referenced
this pull request
Jun 22, 2024
[LLM] Fixed fine-tuning template username setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.