Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nordic characters #1157

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: handle nordic characters #1157

merged 1 commit into from
Jan 15, 2024

Conversation

orhels
Copy link
Contributor

@orhels orhels commented Jan 15, 2024

Status

READY

Description

Fix #1156

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout fix-handle-nordic-characters
> yarn build
> yarn test
  1. Use below schema to generate:
openapi: '3.0.0'
info:
  version: 1.0.0
  title: Swagger ÆrligØnskeÅpen
  license:
    name: MIT
paths:
  /ærligØnskeÅpen:
    get:
      summary: List all ærlig-ønske-åpen
      operationId: listÆrligØnskeÅpen
      responses:
        '200':
          description: A paged array of ærlig-ønske-åpen
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ÆrligØnskeåpen'
components:
  schemas:
    ÆrligØnskeåpen:
      type: object
      required:
        - ærlig
        - ønske
        - åpen
      properties:
        ærlig:
          type: string
        ønske:
          type: string
        åpen:
          type: string
  1. Check that the output respects nordic characters.

@orhels
Copy link
Contributor Author

orhels commented Jan 15, 2024

Let me know if there are any issues or if more info is needed.

packages/core/src/utils/case.ts Outdated Show resolved Hide resolved
@melloware melloware added the bug Something isn't working label Jan 15, 2024
@melloware
Copy link
Collaborator

This looks great running the tests now....

@melloware melloware added this to the 6.24.0 milestone Jan 15, 2024
@melloware melloware merged commit 7e563eb into orval-labs:master Jan 15, 2024
2 checks passed
@orhels orhels deleted the fix-handle-nordic-characters branch January 15, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Nordic characters are ignored
2 participants