Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Nordic characters are ignored #1156

Closed
orhels opened this issue Jan 15, 2024 · 2 comments · Fixed by #1157
Closed

Bug: Nordic characters are ignored #1156

orhels opened this issue Jan 15, 2024 · 2 comments · Fixed by #1157
Assignees
Labels
bug Something isn't working
Milestone

Comments

@orhels
Copy link
Contributor

orhels commented Jan 15, 2024

What are the steps to reproduce this issue?

  1. Use Orval to generate typescript files with the following schema:
openapi: '3.0.0'
info:
  version: 1.0.0
  title: Swagger ÆrligØnskeÅpen
  license:
    name: MIT
paths:
  /ærligØnskeÅpen:
    get:
      summary: List all ærlig-ønske-åpen
      operationId: listÆrligØnskeÅpen
      responses:
        '200':
          description: A paged array of ærlig-ønske-åpen
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ÆrligØnskeåpen'
components:
  schemas:
    ÆrligØnskeåpen:
      type: object
      required:
        - ærlig
        - ønske
        - åpen
      properties:
        ærlig:
          type: string
        ønske:
          type: string
        åpen:
          type: string

What happens?

It generates the file rligNskePen.ts:

export interface RligNskePen {
  ærlig: string;
  åpen: string;
  ønske: string;
}

What were you expecting to happen?

It should generate the file ærligØnskeåpen.ts:

export interface ÆrligØnskeåpen {
  ærlig: string;
  åpen: string;
  ønske: string;
}

Any logs, error output, etc?

Nope.

Any other comments?

I've been testing with different versions of Orval, and the issue starts with 6.18.0.

What versions are you using?

Operating System: MacOs 13.6.3
Package Version: 6.23.0
Browser Version: Chrome 119.0.6045.123

@melloware melloware added the bug Something isn't working label Jan 15, 2024
@melloware
Copy link
Collaborator

My gut feeling is this is the ticket that broke it: #909

@orhels
Copy link
Contributor Author

orhels commented Jan 15, 2024

I have a PR comming where I belive I've fixed the issues. My testing found that #951 was probably the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants