Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume playback not working #904

Closed
mejico opened this issue Sep 19, 2024 · 8 comments
Closed

Resume playback not working #904

mejico opened this issue Sep 19, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@mejico
Copy link

mejico commented Sep 19, 2024

Context

Please provide any relevant information about your setup

  • Add-on Version: v7.0.9.2
  • Kodi Version: 19.4
  • Kodi GUI Language: English
  • Operating System: Windows 11
  • Operating System Language: English

Expected Behaviour:

In the past, when you stopped playing a video and went back to it sometime later it would give you the option to resume play from the time stamp of when you stopped the video.


Current Behaviour

When you stopped playing a video and return to it another time you only have the option to playback the video from the start.


Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Play a video until halfway (assuming the video is longer than 3 minutes long).
  2. Stop the video.
  3. Play the same video again.

Log

kodi Log.txt


Additional Information

This feature was working fine, up until about a week prior to the latest release.


@mejico mejico added the bug Something isn't working label Sep 19, 2024
@MoojMidge
Copy link
Collaborator

Can you get a debug log of playing, stopping then trying to resume a video?

https://kodi.wiki/view/Log_file/Easy

A standard log does not have enough information to determine what the problem may be.

@mejico
Copy link
Author

mejico commented Sep 19, 2024

Will do as soon as I get a chance. Thanks for the reply.

I also should have mentioned that prior to raising the bug report I asked about this problem on the Kodi YouTube plugin thread but the only reply I got was that someone else had the same problem, but unfortunately no solution.

@mejico
Copy link
Author

mejico commented Sep 20, 2024

Sorry about the delay. Here is the debug log.

Cheers
kodi Debug log.txt

@mejico
Copy link
Author

mejico commented Sep 20, 2024

I have noticed that if I restart Kodi, the resume function will work for the first video I play, but will not work for every subsequent video until Kodi is restarted.

MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Sep 20, 2024
MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Sep 20, 2024
@MoojMidge
Copy link
Collaborator

Can you test if the problem is fixed when using this test version?
https://github.com/MoojMidge/plugin.video.youtube/archive/refs/heads/master.zip

@MoojMidge MoojMidge changed the title Resune playback not working Resume playback not working Sep 20, 2024
@mejico
Copy link
Author

mejico commented Sep 21, 2024

Will give it a go and get back to you

Cheers

@mejico
Copy link
Author

mejico commented Sep 21, 2024

That seems to have fixed the problem.
Was the problem caused by changes made by YouTube,?

@MoojMidge
Copy link
Collaborator

Older versions of Kodi have issues with resuming from plugins. This used to be worked around to make it work in this plugin, but has now been largely fixed in more recent versions of Kodi and the old workarounds conflicted with the native Kodi functionality.

This was fixed to work with the native functionality, but this caused a regression on the older versions that still rely on this old behaviour.

TLDR: Upgrade Kodi, there are lots of improvements and it is a lot of work to keep testing how things work on these older releases.

MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Sep 21, 2024
MoojMidge added a commit to MoojMidge/plugin.video.youtube that referenced this issue Sep 21, 2024
@MoojMidge MoojMidge mentioned this issue Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants